KNAB Engine: Key addition for parser ('F' added) #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer KNAB MT940 files contain an F instead of M. (example: ':60F:C200427EUR12490,07') This addition fixes the parser for these files.
PaulvanKaam
changed the title
|
Any chance you might some tests to verify? It seems a no brainier but tests to make sure it keeps working and doesn't contain BC would be great. |
|
Wrote a test that checks the old KNAB sample and a new KNAB sample, checking whether they both still give the expecting result. Let me know if you need anything else to make this pull request happen. |
|
Looks great, done! Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer KNAB MT940 files contain an F instead of M. (example: ':60F:C200427EUR12490,07')
This addition fixes the parser for these files.