Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate comments into English and unify test files by model. #6

Merged
merged 13 commits into from
May 8, 2022
Merged

Conversation

fcno
Copy link
Contributor

@fcno fcno commented May 8, 2022

Proposed changes (mandatory)

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

  1. What is the current behavior? (if appropriate)

    Fixes Issue Number: N/A

  2. What is the new behavior? (if appropriate)

    • Something

    • Else

Pull Request Types (mandatory)

What types of changes does your code introduce? Put an x in the boxes that apply

  • Doc update (non-breaking change which fixes typos or improve readability)

  • [] Bug fix (non-breaking change which fixes an issue)

  • [] New feature (non-breaking change which adds functionality)

  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • [] Other (please describe):

Before you submit a pull request, please make sure you have to following (mandatory)

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.

  • I have commented my code, particularly in hard-to-understand areas.

  • I have made corresponding changes to the documentation.

  • I have read the CONTRIBUTING document.

  • I have added tests that prove my fix is effective or that my feature works.

  • All new and existing tests and lint passed.

Any relevant logs, error output, etc (if appropriate)

Screenshots (if appropriate)

Further comments (if appropriate)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

馃挃Thank you!

@fcno fcno merged commit 09f9236 into 1.x May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant