Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Route View id as self.path #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hxperl
Copy link

@hxperl hxperl commented Feb 9, 2022

I'm using SwiftUIRouter library on company Product, and encounter this issue frequently.
#39

I think that it is better to designate the Rotue's View id as self.path directly in the library than to individually.

@frzi
Copy link
Owner

frzi commented Feb 9, 2022

Hm interesting. I figured if .id() was the fix for this cursed bug then it would be on the Route's Group view instead. I'll have a play with this before pulling.

@3a4oT
Copy link
Contributor

3a4oT commented Mar 10, 2022

Hey, do you have an update on it?

@frzi
Copy link
Owner

frzi commented Apr 12, 2022

Sorry for the radio silence. There's still some testing regarding this - as this can be considered a breaking change. Adding an .id() to anything to SwiftUI can have dramatic side effects regarding states et al.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants