Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Loadout name/desc by clicking on loadout title #2135

Closed
frzyc opened this issue May 15, 2024 · 2 comments · Fixed by #2215
Closed

Edit Loadout name/desc by clicking on loadout title #2135

frzyc opened this issue May 15, 2024 · 2 comments · Fixed by #2215
Assignees
@bluezettabyte
Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR

Comments

@frzyc
Copy link
Owner

frzyc commented May 15, 2024

Similar to #2134

image
@frzyc frzyc added the good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR label May 15, 2024
@bluezettabyte
Copy link
Contributor

I can start working on this issue once I'm able to resolve #2134

@frzyc frzyc mentioned this issue Jun 4, 2024
Merged
5 tasks
@frzyc
Copy link
Owner Author

frzyc commented Jun 4, 2024 •
edited
Loading

@bluezettabyte sorry for the late reply, I was on vacation for the past 2 weeks.
I think I want to resolve both #2134 and this issue at the same time, to have parity of behaviour across team/loadout UI.
I have approved #2164, awaiting a PR resolving this issue.

@bluezettabyte bluezettabyte mentioned this issue Jun 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluezettabyte bluezettabyte

Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to edit loadout name via clicking on loadout name bluezettabyte/genshin-optimizer
2 participants
@frzyc @bluezettabyte