Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit Team name/desc by clicking on team name #2164

Merged
merged 21 commits into from
Jun 8, 2024

Conversation

bluezettabyte
Copy link
Contributor

Describe your changes

  • Allow users to click on team name to edit team name/description

Issue or discord link

Testing/validation

image

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented May 22, 2024

[frontend] [Wed May 22 01:49:44 UTC 2024] - Deployed 7ea730e to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 22 05:56:01 UTC 2024] - Deployed bc80915 to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 23 15:35:41 UTC 2024] - Deployed 4e82bb3 to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue May 28 03:45:41 UTC 2024] - Deployed c3f5f2d to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Jun 2 21:57:32 UTC 2024] - Deployed 5728e5b to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jun 4 20:26:03 UTC 2024] - Deployed 3d11c26 to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Jun 8 15:06:57 UTC 2024] - Deployed 6f12524 to https://genshin-optimizer-prs.github.io/pr/2164/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Jun 8 15:25:59 UTC 2024] - Deleted deployment

libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove these inputs, not that they are moved to the modal?
image

libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 self-requested a review June 2, 2024 21:54
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format errors + one last small change

libs/gi/page-team/src/TeamCharacterSelector.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge in once a PR for #2135 is ready to merge so that we have parity of behaviour across both team/loadout UI.

@frzyc frzyc merged commit 8d29ae8 into frzyc:master Jun 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Team name/desc by clicking on team name
3 participants