Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Graph Axis labels #713

Closed
StainAE86 opened this issue Oct 25, 2022 · 1 comment · Fixed by #722
Closed

Add Graph Axis labels #713

StainAE86 opened this issue Oct 25, 2022 · 1 comment · Fixed by #722
Assignees
Labels
enhancement New feature or request

Comments

@StainAE86
Copy link
Collaborator

Already suggested in #502 however should be bumped to the top of the list.
With the introduction of Graph Opt. Target vs. Opt. Target it's difficult to quickly read the graph and tell which axis is which:

image

Maybe put the name of the character within the Graph as well since its likely people will start sharing their Graph results:

image

@StainAE86 StainAE86 added the enhancement New feature or request label Oct 25, 2022
@nguyentvan7
Copy link
Collaborator

I tried doing this, but seems there is a limitation in the recharts API, though I guess we could just superimpose the labels on top of the chart ourself.

Recharts labels only render strings or numbers, and the labels can sometimes be React components due to translation stuff. Technically they are supposed to support component labels, but it seems bugged

recharts/recharts#1789

nguyentvan7 added a commit that referenced this issue Oct 26, 2022
@frzyc frzyc assigned frzyc and nguyentvan7 and unassigned frzyc Oct 27, 2022
nguyentvan7 added a commit that referenced this issue Oct 29, 2022
* Resolve #713 - Add labels to graph

* Fix undefined textSuffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants