Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional conditional support #1243

Merged
merged 8 commits into from
Sep 8, 2023

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Jul 16, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

[Fri Sep 8 23:31:23 UTC 2023] - Deleted deployment

frzyc
frzyc previously approved these changes Aug 1, 2023
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be working. Ideally, we wouldn't go through so much code churn to implement a requirement like this. This should be a design consideration for Pando Conditionals in the foreseeable future.

@nguyentvan7
Copy link
Collaborator Author

Changed behavior.
Before: Making the state invalid would invalidate the conditional and set it to undefined
Now: Making the state invalid will only visually remove the conditional value. If you make the state valid again, it will still remember your previous choice.

Make Mika C6. Set detector stacks to 4. Change to C5. See that detector stacks is set to "Not Set". Change back to C6. See that detector stacks went back to 4.

@nguyentvan7 nguyentvan7 requested a review from frzyc August 27, 2023 21:12
@nguyentvan7 nguyentvan7 merged commit f1aa88f into master Sep 8, 2023
4 checks passed
@nguyentvan7 nguyentvan7 deleted the van/addConditionalConditionals branch September 8, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a conditional number of conditional states
2 participants