Remove bad sort #1276
Merged
Remove bad sort #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Fri Sep 8 23:04:52 UTC 2023] - Deleted deployment |
frzyc
previously approved these changes
Aug 28, 2023
There was a problem hiding this comment.
A bit of a nitpick for cornercases (Which might not exist)
Objects do not guarantee order. In most cases, they are by insert over, however, if the keys are "number-like" they are sorted ascendingly.
Perhaps if we need to guarantee order, a Map should be used here.
Could be a consideration for Pando Conditionals.
|
Yea that exact cornercase was happening with hydro traveler conditionals with states 0.5, 1, 1.5, etc. Forgot what the order was, but it was not what was expected |
frzyc
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bad sorts like this:
Code was originally there for hydro traveler conditional, since the values were [0.5, 1, 1.5, etc], it was incorrectly sorted for some reason without that call. But we changed the conditional format to not use that, so this change was never needed, and is just a bug now.