-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic character editor #1713
Basic character editor #1713
Conversation
[sr-frontend] [Sat Mar 23 01:26:15 UTC 2024] - Deployed 0301c68 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Mar 24 19:11:09 UTC 2024] - Deployed ac2a76d to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Mar 24 19:11:43 UTC 2024] - Deployed 76a697f to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Mar 24 19:25:22 UTC 2024] - Deployed b1b70d1 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Mar 27 14:32:57 UTC 2024] - Deployed 70986f1 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Mar 30 17:04:59 UTC 2024] - Deployed 8db8956 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Mar 30 17:29:55 UTC 2024] - Deployed f860c07 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Mon Apr 15 14:18:26 UTC 2024] - Deployed 088cc50 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Mon Apr 15 18:25:02 UTC 2024] - Deployed 27830e7 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available) [Mon Apr 15 19:30:54 UTC 2024] - Deleted deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to format (prob need to run yarn
cause i updated the yarn.lock)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry last changes i swear
Describe your changes
Issue or discord link
Testing/validation
Current problems
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.