Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic character editor #1713

Merged
merged 19 commits into from
Apr 15, 2024
Merged

Basic character editor #1713

merged 19 commits into from
Apr 15, 2024

Conversation

priolette
Copy link
Contributor

Describe your changes

  • Implement ability to change eidolons, skill levels, traces and bonus stats
  • Add hot reloading to Vite config in SRO
  • Create new character when choosing it in the top dropdown

Issue or discord link

Testing/validation

Screenshot 2024-03-14 at 10 40 27

Current problems

  • Traces and bonus stats do not take into account character ascension or level

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Mar 23, 2024

[sr-frontend] [Sat Mar 23 01:26:15 UTC 2024] - Deployed 0301c68 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Mar 24 19:11:09 UTC 2024] - Deployed ac2a76d to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Mar 24 19:11:43 UTC 2024] - Deployed 76a697f to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Mar 24 19:25:22 UTC 2024] - Deployed b1b70d1 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Mar 27 14:32:57 UTC 2024] - Deployed 70986f1 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Mar 30 17:04:59 UTC 2024] - Deployed 8db8956 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Mar 30 17:29:55 UTC 2024] - Deployed f860c07 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Apr 15 14:18:26 UTC 2024] - Deployed 088cc50 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Apr 15 18:25:02 UTC 2024] - Deployed 27830e7 to https://genshin-optimizer-prs.github.io/pr/1713/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Mon Apr 15 19:30:54 UTC 2024] - Deleted deployment

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to format (prob need to run yarn cause i updated the yarn.lock)

apps/sr-frontend/src/app/Character.tsx Show resolved Hide resolved
apps/sr-frontend/src/app/Character.tsx Show resolved Hide resolved
@priolette priolette marked this pull request as ready for review March 24, 2024 19:30
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

apps/sr-frontend/src/app/Character.tsx Outdated Show resolved Hide resolved
apps/sr-frontend/src/app/Character.tsx Show resolved Hide resolved
apps/sr-frontend/src/app/CharacterSelector.tsx Outdated Show resolved Hide resolved
libs/sr/ui/src/Character/AbilityDropdown.tsx Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 added the SRO For Star Rail Optimizer label Apr 13, 2024
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry last changes i swear

apps/sr-frontend/src/app/Character.tsx Outdated Show resolved Hide resolved
apps/sr-frontend/src/app/Character.tsx Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 requested a review from frzyc April 15, 2024 19:09
@nguyentvan7 nguyentvan7 merged commit 3273f16 into frzyc:master Apr 15, 2024
6 checks passed
@priolette priolette deleted the char-info branch April 16, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants