-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1549 add relic viewer #1881
1549 add relic viewer #1881
Conversation
[sr-frontend] [Mon Apr 1 20:08:09 UTC 2024] - Deployed 08f0439 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Apr 3 10:43:10 UTC 2024] - Deployed f772287 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Apr 3 14:52:35 UTC 2024] - Deployed fe4edbe to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Apr 16 18:30:52 UTC 2024] - Deployed 2d64aff to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Apr 16 19:33:46 UTC 2024] - Deployed 064cc89 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Fri Apr 19 17:24:30 UTC 2024] - Deployed 2a21477 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available) [Fri Apr 19 17:32:30 UTC 2024] - Deleted deployment |
If you want to link your PR to the issue, edit your description to:
|
nit: wrap the component in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more cleanup
format issues |
oops and they were my fault :^) |
Describe your changes
Created RelicInventory to display relics on a grid using the RelicCard. The in-house infinite scroll has been used for this.
Issue or discord link
Resolves #1549
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.