Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1549 add relic viewer #1881

Merged
merged 12 commits into from
Apr 19, 2024
Merged

1549 add relic viewer #1881

merged 12 commits into from
Apr 19, 2024

Conversation

EuEric
Copy link
Contributor

@EuEric EuEric commented Apr 1, 2024

Describe your changes

Created RelicInventory to display relics on a grid using the RelicCard. The in-house infinite scroll has been used for this.

Issue or discord link

Resolves #1549

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 1, 2024

[sr-frontend] [Mon Apr 1 20:08:09 UTC 2024] - Deployed 08f0439 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Apr 3 10:43:10 UTC 2024] - Deployed f772287 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Apr 3 14:52:35 UTC 2024] - Deployed fe4edbe to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 16 18:30:52 UTC 2024] - Deployed 2d64aff to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 16 19:33:46 UTC 2024] - Deployed 064cc89 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Apr 19 17:24:30 UTC 2024] - Deployed 2a21477 to https://genshin-optimizer-prs.github.io/pr/1881/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Fri Apr 19 17:32:30 UTC 2024] - Deleted deployment

apps/sr-frontend/src/app/App.tsx Outdated Show resolved Hide resolved
libs/sr/ui/src/Relic/RelicInventory.tsx Outdated Show resolved Hide resolved
libs/sr/ui/src/Relic/RelicInventory.tsx Outdated Show resolved Hide resolved
@frzyc
Copy link
Owner

frzyc commented Apr 3, 2024

If you want to link your PR to the issue, edit your description to:

Issue or discord link
- Resolves #1549

apps/sr-frontend/src/app/App.tsx Outdated Show resolved Hide resolved
nguyentvan7
nguyentvan7 previously approved these changes Apr 3, 2024
@frzyc
Copy link
Owner

frzyc commented Apr 3, 2024

nit: wrap the component in a <CardThemed> to make it not blend in with background

Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more cleanup

apps/sr-frontend/src/app/App.tsx Outdated Show resolved Hide resolved
@nguyentvan7 nguyentvan7 added the SRO For Star Rail Optimizer label Apr 13, 2024
@nguyentvan7
Copy link
Collaborator

format issues

@nguyentvan7
Copy link
Collaborator

oops and they were my fault :^)

@nguyentvan7 nguyentvan7 mentioned this pull request Apr 19, 2024
5 tasks
@nguyentvan7 nguyentvan7 requested a review from frzyc April 19, 2024 17:29
@nguyentvan7 nguyentvan7 merged commit 5cad74c into frzyc:master Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relic viewer UI
3 participants