Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArtifactSetTooltip Translation #1941

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix ArtifactSetTooltip Translation #1941

merged 1 commit into from
Apr 12, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 11, 2024

Describe your changes

image

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc changed the title fix ArtifactSetTooltip Translation Fix ArtifactSetTooltip Translation Apr 11, 2024
Copy link
Contributor

[frontend] [Thu Apr 11 11:58:02 UTC 2024] - Deployed d4647a3 to https://genshin-optimizer-prs.github.io/pr/1941/frontend (Takes 3-5 minutes after this completes to be available)

@frzyc frzyc self-assigned this Apr 11, 2024
@frzyc frzyc merged commit 988a588 into master Apr 12, 2024
6 checks passed
@frzyc frzyc deleted the 1935 branch April 12, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact set description tooltip on build is broken
2 participants