Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow defaulting to 1st char in team UI #1947

Merged
merged 3 commits into from
Apr 12, 2024
Merged

allow defaulting to 1st char in team UI #1947

merged 3 commits into from
Apr 12, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 12, 2024

Describe your changes

When clicking on the teamcard title

Issue or discord link

Testing/validation

  • Enter team from teamcard title -> default to 1st character
  • after defaulting to 1st character, press back go back to previous page
  • History is preserved across other changes (e.g. default to 1st character, switch character)

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 12, 2024

[frontend] [Fri Apr 12 11:47:45 UTC 2024] - Deployed 1f1d6c2 to https://genshin-optimizer-prs.github.io/pr/1947/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Apr 12 12:06:16 UTC 2024] - Deployed dcd457d to https://genshin-optimizer-prs.github.io/pr/1947/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Apr 12 12:20:38 UTC 2024] - Deployed a644efa to https://genshin-optimizer-prs.github.io/pr/1947/frontend (Takes 3-5 minutes after this completes to be available)

[Fri Apr 12 19:54:30 UTC 2024] - Deleted deployment

@frzyc frzyc self-assigned this Apr 12, 2024
@frzyc frzyc requested a review from nguyentvan7 April 12, 2024 12:01
@frzyc frzyc marked this pull request as ready for review April 12, 2024 12:01
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I was just about to make an issue about the history being all messed up

@frzyc frzyc merged commit b2e221f into master Apr 12, 2024
6 checks passed
@frzyc frzyc deleted the team_no_char branch April 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants