Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerranges sub-stats filters #1948

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

BobinChen1
Copy link
Contributor

@BobinChen1 BobinChen1 commented Apr 12, 2024

Describe your changes

Rerranges sub-stats filters

Issue or discord link

Resolve #1827

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 12, 2024

[frontend] [Fri Apr 12 12:33:54 UTC 2024] - Deployed 74470ef to https://genshin-optimizer-prs.github.io/pr/1948/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Apr 12 12:40:59 UTC 2024] - Deployed b43d7f3 to https://genshin-optimizer-prs.github.io/pr/1948/frontend (Takes 3-5 minutes after this completes to be available)

[Fri Apr 12 12:49:01 UTC 2024] - Deleted deployment

- Removes unnecessary substat translation
@BobinChen1 BobinChen1 force-pushed the bchen/rearrange-artifact-filter-ui branch from 64754f3 to e991dbe Compare April 12, 2024 12:36
@BobinChen1 BobinChen1 requested a review from frzyc April 12, 2024 12:40
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frzyc frzyc merged commit bc522e9 into frzyc:master Apr 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearrange Artifact Filter UI
2 participants