Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overview burst cut off #1952

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Conversation

nicospz
Copy link
Contributor

@nicospz nicospz commented Apr 13, 2024

Describe your changes

Issue or discord link

Testing/validation

Before After
image image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 13, 2024

[frontend] [Sat Apr 13 06:59:15 UTC 2024] - Deployed cf6715e to https://genshin-optimizer-prs.github.io/pr/1952/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Apr 13 11:38:58 UTC 2024] - Deleted deployment

Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice type fix as well. 👍

@frzyc frzyc merged commit 19dc78a into frzyc:master Apr 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talent levels are cut off in character modal
2 participants