Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pressing Enter from the Build Name field to create a team #1957

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

nicospz
Copy link
Contributor

@nicospz nicospz commented Apr 14, 2024

Describe your changes

  • Allows triggering the Create action using Enter.
  • Also fixed the TextField auto-focus that wasn't working. Got the solution from here.

Issue or discord link

Testing/validation

Enter.mp4

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 14, 2024

[frontend] [Sun Apr 14 01:39:56 UTC 2024] - Deployed 0aea0fe to https://genshin-optimizer-prs.github.io/pr/1957/frontend (Takes 3-5 minutes after this completes to be available)

[Sun Apr 14 03:33:30 UTC 2024] - Deleted deployment

@nicospz nicospz changed the title Build name enter create Allow pressing Enter from the Build Name field to create a team Apr 14, 2024
@frzyc
Copy link
Owner

frzyc commented Apr 14, 2024

LGTM, thanks for your work!

@frzyc frzyc merged commit 38fdf6b into frzyc:master Apr 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Allow pressing "Enter" from the Build Name entry box to Create the team
2 participants