Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GO page on go-next #1958

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Use GO page on go-next #1958

merged 2 commits into from
Apr 16, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 14, 2024

Describe your changes

Allow using GO's page libs in go-next. This is proof that we no longer need to have dedicated go-next components, and can share components with the main site.
Currently, Implemented the artifact page.
image
The main sticking point is the ability to conditionally use NextJS's Image component in NextJS environment.

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 14, 2024

[sr-frontend] [Sun Apr 14 02:16:30 UTC 2024] - Deployed 5d9eb7c to https://genshin-optimizer-prs.github.io/pr/1958/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Apr 14 02:19:21 UTC 2024] - Deployed 5d9eb7c to https://genshin-optimizer-prs.github.io/pr/1958/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Apr 15 00:05:04 UTC 2024] - Deployed 89e7baa to https://genshin-optimizer-prs.github.io/pr/1958/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 15 00:06:31 UTC 2024] - Deployed 89e7baa to https://genshin-optimizer-prs.github.io/pr/1958/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Apr 15 22:36:55 UTC 2024] - Deployed 4c2946e to https://genshin-optimizer-prs.github.io/pr/1958/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 15 22:37:15 UTC 2024] - Deployed 4c2946e to https://genshin-optimizer-prs.github.io/pr/1958/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Apr 16 00:49:30 UTC 2024] - Deleted deployment

@frzyc frzyc requested a review from nguyentvan7 April 14, 2024 03:26
@frzyc frzyc requested a review from nguyentvan7 April 14, 2024 23:58
@frzyc frzyc added the go-next GO with NextJS and backend label Apr 15, 2024
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see reply

@frzyc frzyc requested a review from nguyentvan7 April 15, 2024 22:35
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the threads thing

@frzyc frzyc merged commit 950f51b into master Apr 16, 2024
7 checks passed
@frzyc frzyc deleted the go_next_lib branch April 16, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go-next GO with NextJS and backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants