-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GO page on go-next #1958
Use GO page on go-next #1958
Conversation
[sr-frontend] [Sun Apr 14 02:16:30 UTC 2024] - Deployed 5d9eb7c to https://genshin-optimizer-prs.github.io/pr/1958/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Apr 14 02:19:21 UTC 2024] - Deployed 5d9eb7c to https://genshin-optimizer-prs.github.io/pr/1958/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Mon Apr 15 00:05:04 UTC 2024] - Deployed 89e7baa to https://genshin-optimizer-prs.github.io/pr/1958/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Apr 15 00:06:31 UTC 2024] - Deployed 89e7baa to https://genshin-optimizer-prs.github.io/pr/1958/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Mon Apr 15 22:36:55 UTC 2024] - Deployed 4c2946e to https://genshin-optimizer-prs.github.io/pr/1958/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Apr 15 22:37:15 UTC 2024] - Deployed 4c2946e to https://genshin-optimizer-prs.github.io/pr/1958/frontend (Takes 3-5 minutes after this completes to be available) [Tue Apr 16 00:49:30 UTC 2024] - Deleted deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see reply
libs/gi/page-team/src/CharacterDisplay/Tabs/TabOptimize/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the threads thing
Describe your changes
Allow using GO's page libs in go-next. This is proof that we no longer need to have dedicated go-next components, and can share components with the main site.
Currently, Implemented the artifact page.
The main sticking point is the ability to conditionally use NextJS's Image component in NextJS environment.
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.