UIData Refactoring

[frzyc]

Describe your changes

mimi branch for mini-migration

• Added UIData.newGet and newGetNodeDisplay to replace UIData.get and computeNodeDisplay

• UIData.newGet returns CalcResult, then pass that value into newGetNodeDisplay to get CalcDisplay.

  • Both CalcResult and CalcDisplay should contain all information that NodeDisplay has, albeit in different order/format (Check computeNodeDisplay for the conversion)

TODO:

• convert UIData.getAll, UIData.getTeamBuff, UIData.getDisplay to use the new type format (NodeDisplay -> CalcDisplay)
• convert the downstream calls to use UIData.get
• There're a few TODOs in the UIData, but shouldn't need to touch them too much
• move all UI-related stuffs to a separate library safely

Issue or discord link

Testing/validation

Before: with intention to remove dependency,

After:

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

• I have commented my code in hard-to understand areas.
• I have made corresponding changes to README or wiki.
• For front-end changes, I have updated the corresponding English translations.
• I have run yarn run mini-ci locally to validate format and lint.
• If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

[github-actions]

[frontend] [Mon Apr 15 14:15:25 UTC 2024] - Deployed 85767fc to https://genshin-optimizer-prs.github.io/pr/1964/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 15 17:10:05 UTC 2024] - Deployed 885763e to https://genshin-optimizer-prs.github.io/pr/1964/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 16 04:30:08 UTC 2024] - Deployed b8f4bc3 to https://genshin-optimizer-prs.github.io/pr/1964/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 16 15:14:06 UTC 2024] - Deployed 9d11a4b to https://genshin-optimizer-prs.github.io/pr/1964/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Apr 16 17:46:37 UTC 2024] - Deleted deployment

[nguyentvan7]

/shrug

[lantua]

lgtm