Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix team page rerender after revalidating character #1969

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix team page rerender after revalidating character #1969

merged 1 commit into from
Apr 16, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 15, 2024

Describe your changes

Revert to using navigate, but to not conflict with rendering state, wrap the function in a useEffect

Issue or discord link

Testing/validation

  • Create new team, add a character then remove character, does not close team setting
  • Create team with 2 char, removing the 1st char would cause 2nd char to shift to 1st slot without closing team setting

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 April 15, 2024 23:24
@frzyc frzyc added the bug Something isn't working label Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

[frontend] [Mon Apr 15 23:26:06 UTC 2024] - Deployed 08e35bf to https://genshin-optimizer-prs.github.io/pr/1969/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 15 23:27:53 UTC 2024] - Deployed 08e35bf to https://genshin-optimizer-prs.github.io/pr/1969/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Apr 16 01:07:34 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit d38305d into master Apr 16, 2024
7 checks passed
@frzyc frzyc deleted the 1968 branch April 16, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing team state can lead to rerenders that closes the team settings
2 participants