Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanup for go-next #1980

Merged
merged 1 commit into from
Apr 17, 2024
Merged

minor cleanup for go-next #1980

merged 1 commit into from
Apr 17, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 17, 2024

Describe your changes

  • Update NextJS version to see if it improves dev performance (seems like it does not)
  • Use the same SillyContext from @go/gi/ui, remove the one in @go/gi/ui-next
  • Use a singleton for the PrismaClient to battle duplicate clients on reload while dev
  • Test out weapons page for data connection between pages in SSR

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 April 17, 2024 02:54
Copy link
Contributor

github-actions bot commented Apr 17, 2024

[sr-frontend] [Wed Apr 17 02:57:01 UTC 2024] - Deployed 627a20c to https://genshin-optimizer-prs.github.io/pr/1980/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Apr 17 02:58:54 UTC 2024] - Deployed 627a20c to https://genshin-optimizer-prs.github.io/pr/1980/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Apr 17 13:36:50 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit b319332 into master Apr 17, 2024
7 checks passed
@frzyc frzyc deleted the next_cleanup branch April 17, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants