Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split worker work more evenly #1983

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Split worker work more evenly #1983

merged 1 commit into from
Apr 17, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

Use a slightly more sophisticated method to split worker work more evenly, based on the slot with the most relics.

Issue or discord link

Testing/validation

  • Verified via logging that work is as evenly distributed as possible for small case (24 total perms) and large case (128 million perms)
  • Verified that optimization in both cases reports the correct number of calculated builds

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 added the SRO For Star Rail Optimizer label Apr 17, 2024
@nguyentvan7 nguyentvan7 requested a review from frzyc April 17, 2024 05:16
Copy link
Contributor

github-actions bot commented Apr 17, 2024

[sr-frontend] [Wed Apr 17 05:18:57 UTC 2024] - Deployed c91f274 to https://genshin-optimizer-prs.github.io/pr/1983/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Wed Apr 17 15:11:56 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit f94295f into master Apr 17, 2024
7 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/workerOpt branch April 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants