Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock function to ArtifactCard #1984

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add lock function to ArtifactCard #1984

merged 1 commit into from
Apr 18, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 17, 2024

Describe your changes

Issue or discord link

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 April 17, 2024 15:08
@frzyc frzyc self-assigned this Apr 17, 2024
Copy link
Contributor

github-actions bot commented Apr 17, 2024

[frontend] [Wed Apr 17 15:12:03 UTC 2024] - Deployed e8672a7 to https://genshin-optimizer-prs.github.io/pr/1984/frontend (Takes 3-5 minutes after this completes to be available)

[Thu Apr 18 00:43:52 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit e189b1b into master Apr 18, 2024
6 checks passed
@frzyc frzyc deleted the 1979 branch April 18, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing lock button on artifactcard in artifact page
2 participants