Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header to SRO #1988

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add header to SRO #1988

merged 2 commits into from
Apr 19, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Apr 18, 2024

Describe your changes

Added a header and basic routing components to SRO (copied from GO) so we can divvy up components into pages
image

Issue or discord link

Testing/validation

Tested scrolltop works on SRO and GO

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc April 18, 2024 21:19
@nguyentvan7 nguyentvan7 added the SRO For Star Rail Optimizer label Apr 18, 2024
Copy link
Contributor

github-actions bot commented Apr 18, 2024

[sr-frontend] [Thu Apr 18 21:21:57 UTC 2024] - Deployed e63a818 to https://genshin-optimizer-prs.github.io/pr/1988/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu Apr 18 21:22:14 UTC 2024] - Deployed e63a818 to https://genshin-optimizer-prs.github.io/pr/1988/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Apr 18 21:22:39 UTC 2024] - Deployed e63a818 to https://genshin-optimizer-prs.github.io/pr/1988/frontend (Takes 3-5 minutes after this completes to be available)

[Fri Apr 19 14:00:10 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit 1b802ef into master Apr 19, 2024
9 checks passed
@nguyentvan7 nguyentvan7 deleted the van/sro/header branch April 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SRO] Create header for navigation
2 participants