Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes a UI fix for No Reactions being greyed out #1990

Merged

Conversation

BobinChen1
Copy link
Contributor

Describe your changes

Makes UI change so that No Reaction is not greyed out by default

Issue or discord link

Resolve #1652

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Apr 18, 2024

[frontend] [Thu Apr 18 23:09:10 UTC 2024] - Deployed 70d7fc0 to https://genshin-optimizer-prs.github.io/pr/1990/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Apr 18 23:10:32 UTC 2024] - Deployed cf79e79 to https://genshin-optimizer-prs.github.io/pr/1990/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Apr 18 23:16:13 UTC 2024] - Deployed 78db1a7 to https://genshin-optimizer-prs.github.io/pr/1990/frontend (Takes 3-5 minutes after this completes to be available)

[Fri Apr 19 01:36:56 UTC 2024] - Deleted deployment

@BobinChen1 BobinChen1 force-pushed the bchen/1652/No-Reactions-Default-State branch from 7b39441 to 0990234 Compare April 18, 2024 23:13
@frzyc frzyc merged commit 071c707 into frzyc:master Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No Reactions" default state
2 participants