Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Character Selection Modal constant size #1994

Merged

Conversation

BobinChen1
Copy link
Contributor

Describe your changes

Makes Character Selection Modal height based on view height and makes filters always stay visible while scrolling

Issue or discord link

N/A

Testing/validation

Desktop 2024 04 19 - 09 37 47 04

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@BobinChen1 BobinChen1 marked this pull request as draft April 19, 2024 14:53
Copy link
Contributor

github-actions bot commented Apr 19, 2024

[frontend] [Fri Apr 19 14:56:21 UTC 2024] - Deployed 4cc0db9 to https://genshin-optimizer-prs.github.io/pr/1994/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Apr 19 15:23:23 UTC 2024] - Deployed bb6c182 to https://genshin-optimizer-prs.github.io/pr/1994/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Apr 19 15:23:33 UTC 2024] - Deployed 6630541 to https://genshin-optimizer-prs.github.io/pr/1994/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Apr 20 15:25:58 UTC 2024] - Deployed f29b5a4 to https://genshin-optimizer-prs.github.io/pr/1994/frontend (Takes 3-5 minutes after this completes to be available)

[Sun Apr 21 04:38:08 UTC 2024] - Deleted deployment

@BobinChen1 BobinChen1 marked this pull request as ready for review April 19, 2024 15:20
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little cramped on mobile, but still seems fine to me

@frzyc frzyc merged commit f285b2e into frzyc:master Apr 21, 2024
6 checks passed
@frzyc frzyc mentioned this pull request Apr 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants