Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create basic Light Cone page #2003

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Create basic Light Cone page #2003

merged 3 commits into from
Apr 22, 2024

Conversation

tiffanynwyeung
Copy link
Contributor

@tiffanynwyeung tiffanynwyeung commented Apr 21, 2024 •
edited by nguyentvan7

Describe your changes

  • Generate new library for Light Cone tab on SRO, page-lightcones
  • Update Header to include LightCone tab
  • Move components LightConeEditor and LightConeInventory to only be displayed in the Light Cone tab, remove references to it on PageHome

Issue or discord link

Testing/validation

New header:
image

New Light Cone page with example entries added:
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@tiffanynwyeung tiffanynwyeung changed the title Create Light Cone page Create basic Light Cone page Apr 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2024 •
edited

[frontend] [Sun Apr 21 07:45:59 UTC 2024] - Deployed e4b2732 to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Apr 21 07:49:51 UTC 2024] - Deployed 3f63e4a to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Apr 21 09:15:31 UTC 2024] - Deployed 93b9fe6 to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Apr 21 15:51:42 UTC 2024] - Deployed d1dcc80 to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Apr 22 02:53:41 UTC 2024] - Deployed 4a29a60 to https://genshin-optimizer-prs.github.io/pr/2003/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 22 02:54:15 UTC 2024] - Deployed 4a29a60 to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 22 09:30:21 UTC 2024] - Deployed accb16c to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Apr 22 15:25:36 UTC 2024] - Deployed 2f3774c to https://genshin-optimizer-prs.github.io/pr/2003/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Apr 22 15:26:08 UTC 2024] - Deployed 2f3774c to https://genshin-optimizer-prs.github.io/pr/2003/frontend (Takes 3-5 minutes after this completes to be available)

[Mon Apr 22 16:53:34 UTC 2024] - Deleted deployment

nguyentvan7
nguyentvan7 reviewed Apr 21, 2024
View reviewed changes
tsconfig.base.json Outdated Show resolved Hide resolved
@tiffanynwyeung
fix bugs preventing proper build, add new mac cache packages
328479f 
fixed the following:
- overlooked editing tsconfig.base.json to use correct extension
- accidentally included 'shouldShowDevComponents' flag from GI libs and breaking build
@tiffanynwyeung
track current db state to autoupdate LC inventory, minor UI edits
401b019 
- add listener to current db state to autoupdate LC inventory when new LC added
- remove LC inventory accordion component as it's no longer necessary
- add temporary sort on LC inventory to prevent cards shuffling due to db state changing between hard page refreshes; proper sort implemented in follow-up PR
nguyentvan7
nguyentvan7 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@nguyentvan7 nguyentvan7 merged commit 7cf0f4a into frzyc:master Apr 22, 2024
7 checks passed
@tiffanynwyeung tiffanynwyeung deleted the sro/create-lightcones-page branch April 23, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyentvan7 nguyentvan7 nguyentvan7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move LightConeInventory and LightConeEditor to Light Cone page
2 participants
@tiffanynwyeung @nguyentvan7