add a more robust ad framework #2005
Conversation
|
[sr-frontend] [Sun Apr 21 23:05:32 UTC 2024] - Deployed 31a3101 to https://genshin-optimizer-prs.github.io/pr/2005/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Apr 21 23:06:46 UTC 2024] - Deployed 31a3101 to https://genshin-optimizer-prs.github.io/pr/2005/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Apr 21 23:30:12 UTC 2024] - Deployed 4402e66 to https://genshin-optimizer-prs.github.io/pr/2005/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Apr 21 23:30:51 UTC 2024] - Deployed 4402e66 to https://genshin-optimizer-prs.github.io/pr/2005/frontend (Takes 3-5 minutes after this completes to be available) [Mon Apr 22 18:09:29 UTC 2024] - Deleted deployment |
| }) { | ||
| const Comp = useMemo(() => { | ||
| const components: Array<FunctionComponent<{ children: ReactNode }>> = [GOAd] | ||
| if (height === undefined || canshowGoDevAd(height)) components.push(GODevAd) |
There was a problem hiding this comment.
Doesn't have to be this PR, but another fake ad for our playlist series would be nice too
| return ( | ||
| <Box | ||
| sx={{ | ||
| backgroundColor: 'white !important', |
There was a problem hiding this comment.
The white color is a bit jarring, but maybe that's the point
Describe your changes
Issue or discord link
Testing/validation
on dev (placeholder ads)
on deployment (with placed ads)
WARNING: backup your prod database
https://frzyc.github.io/genshin-optimizer-beta
Ads are not fully filled, since the non-desired ads (content/siderail) ads are still enabled for prod
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.