Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more responsive ads #2011

Merged
merged 3 commits into from
Apr 24, 2024
Merged

more responsive ads #2011

merged 3 commits into from
Apr 24, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Apr 24, 2024

Describe your changes

Ads are not being displayed properly, needed to make ads more adjustable for different layout conditions.
https://support.google.com/adsense/answer/9183363?hl=en&ref_topic=9183242&sjid=6550905263099832313-NC#
This should resolve top/bottom banner ad not rendering:
Screenshot 2024-04-23 134920
Also some handling of intent ads

Issue or discord link

Testing/validation

(open this in a incognito window to avoid db contamination) https://frzyc.github.io/genshin-optimizer-beta/
image

Moving Intend Ad above the footer
Screenshot 2024-04-24 002828

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 April 24, 2024 01:32
Copy link
Contributor

github-actions bot commented Apr 24, 2024

[sr-frontend] [Wed Apr 24 01:35:27 UTC 2024] - Deployed 3037634 to https://genshin-optimizer-prs.github.io/pr/2011/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Apr 24 01:35:54 UTC 2024] - Deployed 3037634 to https://genshin-optimizer-prs.github.io/pr/2011/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Apr 24 01:57:54 UTC 2024] - Deployed c6f0846 to https://genshin-optimizer-prs.github.io/pr/2011/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Apr 24 01:58:42 UTC 2024] - Deployed c6f0846 to https://genshin-optimizer-prs.github.io/pr/2011/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Apr 24 04:40:21 UTC 2024] - Deployed 8ff9c0b to https://genshin-optimizer-prs.github.io/pr/2011/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Apr 24 04:41:02 UTC 2024] - Deployed 8ff9c0b to https://genshin-optimizer-prs.github.io/pr/2011/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Apr 24 17:14:59 UTC 2024] - Deployed f2d40c6 to https://genshin-optimizer-prs.github.io/pr/2011/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Apr 24 17:16:17 UTC 2024] - Deployed f2d40c6 to https://genshin-optimizer-prs.github.io/pr/2011/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Apr 24 17:39:51 UTC 2024] - Deleted deployment

nguyentvan7
nguyentvan7 previously approved these changes Apr 24, 2024
@nguyentvan7 nguyentvan7 added bug Something isn't working and removed bug Something isn't working labels Apr 24, 2024
@frzyc frzyc merged commit 74d801d into master Apr 24, 2024
9 checks passed
@frzyc frzyc deleted the respon_ads branch April 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants