Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.6 content; adjust things for 4.6 data #2012

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Add 4.6 content; adjust things for 4.6 data #2012

merged 9 commits into from
Apr 24, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Add Arlecchino
  • Add Crimson Moon's Semblance (weapon)
  • Add Fragment of Harmonic Whimsy and Unfinished Reverie (artifacts)
  • Remove usage of extrapolateFloat now that datamine is providing proper values
  • Adjust EquipAffixId -> equipAffixId according to DM name change
  • Regenerated various files after extrapolateFloat removal

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc April 24, 2024 03:21
Copy link
Contributor

github-actions bot commented Apr 24, 2024

[frontend] [Wed Apr 24 03:25:15 UTC 2024] - Deployed 36241af to https://genshin-optimizer-prs.github.io/pr/2012/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Apr 24 05:35:14 UTC 2024] - Deployed 81f02f5 to https://genshin-optimizer-prs.github.io/pr/2012/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Apr 24 16:41:59 UTC 2024] - Deleted deployment

frzyc
frzyc previously approved these changes Apr 24, 2024
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't vouch for the correctness of the sheets, but looks logically fine to me.

@nguyentvan7 nguyentvan7 merged commit 7021030 into master Apr 24, 2024
6 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/arle branch April 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants