Fix the parsing error of Issue #2029 #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the replace from , -> . to , -> nothing, because the stat got interpreted as a float and in a later step rounded down to 1
|
[frontend] [Tue Apr 30 15:06:53 UTC 2024] - Deployed 0927c02 to https://genshin-optimizer-prs.github.io/pr/2052/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Apr 30 19:04:44 UTC 2024] - Deployed fccd490 to https://genshin-optimizer-prs.github.io/pr/2052/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed May 1 05:09:58 UTC 2024] - Deployed 26c89fc to https://genshin-optimizer-prs.github.io/pr/2052/frontend (Takes 3-5 minutes after this completes to be available) [Wed May 1 05:37:32 UTC 2024] - Deleted deployment |
frzyc
requested changes
Apr 30, 2024
LukasHuth
added a commit
to LukasHuth/genshin-optimizer
that referenced
this pull request
Apr 30, 2024
I changed the code, so that the `,` or `.` only gets deleted if they are followed by 3 digits. Since artifacts only have a precision of one digit this method should not delete any `,` or `.` used for floating point seperation.
I changed the code, so that the `,` or `.` only gets deleted if they are followed by 3 digits. Since artifacts only have a precision of one digit this method should not delete any `,` or `.` used for floating point seperation.
frzyc
requested changes
Apr 30, 2024
|
Also need to format using |
Add forgotten `\` to escape the `.` of the regex Co-authored-by: frzyc <frzyc@users.noreply.github.com>
the regex caught .000 but also everything abouve like .00000 and now it olny catches, if the `.` is followed by 3 `0`s. I also ran `yarn run mini-ci` this time.
frzyc
approved these changes
May 1, 2024
|
LGTM, thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I changed the replace from , -> . to , -> nothing, because the stat got interpreted as a float and in a later step rounded down to 1
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.