Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor level slider refactor #2060

Merged
merged 1 commit into from
May 2, 2024
Merged

minor level slider refactor #2060

merged 1 commit into from
May 2, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented May 2, 2024

Describe your changes

  • Address padding around level slider in opt tab
  • more dynamic border radius.

Issue or discord link

Testing/validation

Before
Screenshot 2024-05-02 115135
After
Screenshot 2024-05-02 120131

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 May 2, 2024 16:02
Copy link
Contributor

github-actions bot commented May 2, 2024

[frontend] [Thu May 2 16:05:21 UTC 2024] - Deployed d538675 to https://genshin-optimizer-prs.github.io/pr/2060/frontend (Takes 3-5 minutes after this completes to be available)

[Thu May 2 22:07:30 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit 470b7c0 into master May 2, 2024
6 checks passed
@frzyc frzyc deleted the level_slider branch May 2, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants