Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Setting refactor: resonance revamp, clickable team char #2065

Merged
merged 3 commits into from
May 4, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented May 3, 2024

Describe your changes

  • Move Resonance above teams, so team would not seem cramped with 5 columns. Revert to 4 columns.
  • Resonance adopts to team resonance status, show possible resonance when team is not full.
  • Since Resonance UI adds extra space between header and team, allow clicking on char card for Team Setting Character click nav #1688

Issue or discord link

Testing/validation

With resonance
image

No resonance
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 May 3, 2024 04:59
Copy link
Contributor

github-actions bot commented May 3, 2024

[frontend] [Fri May 3 05:02:59 UTC 2024] - Deployed 1491208 to https://genshin-optimizer-prs.github.io/pr/2065/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri May 3 06:20:26 UTC 2024] - Deployed 40cc357 to https://genshin-optimizer-prs.github.io/pr/2065/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri May 3 06:25:10 UTC 2024] - Deployed 3557a23 to https://genshin-optimizer-prs.github.io/pr/2065/frontend (Takes 3-5 minutes after this completes to be available)

[Sat May 4 14:47:33 UTC 2024] - Deleted deployment

nguyentvan7
nguyentvan7 previously approved these changes May 3, 2024
@frzyc frzyc requested review from nguyentvan7 and removed request for nguyentvan7 May 3, 2024 06:22
@frzyc frzyc merged commit ab12fa0 into master May 4, 2024
6 checks passed
@frzyc frzyc deleted the team_setting_refactor branch May 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team resonance UI revamp Team Setting Character click nav
2 participants