Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCard refactor #2082

Merged
merged 5 commits into from
May 9, 2024
Merged

TeamCard refactor #2082

merged 5 commits into from
May 9, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented May 9, 2024

Describe your changes

Team cards currently only show the team name, and the 4 characters in the team.
However, it doesn't really tell which loadout/build the characters are using, which infers a lot of context in how the team is used.
The loadout and builds are only shown on hovering over each character.

This is an alternative layout for the teamcard, that shows all that data without the hovering barrier.

Additionally, remove the SqBadges in artifact/weaponcardpico. It was adding too much color and blocking out too much realestate on those tiny cards.

Issue or discord link

Testing/validation

Screenshot 2024-05-09 023255

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 May 9, 2024 06:37
Copy link
Contributor

github-actions bot commented May 9, 2024

[frontend] [Thu May 9 06:41:10 UTC 2024] - Deployed 9f4d16d to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 9 06:42:49 UTC 2024] - Deployed cb8a8b9 to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 9 06:46:39 UTC 2024] - Deployed 38c8c23 to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 9 19:06:34 UTC 2024] - Deployed cabab95 to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available)

[Thu May 9 19:29:29 UTC 2024] - Deleted deployment

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shading comment
+
Should we make the team name+header a bit bigger? maybe 2 line tall? Kinda depends on if people identify teams via characters or name primarily maybe.

@frzyc
Copy link
Owner Author

frzyc commented May 9, 2024

Shading comment

What's a Shading comment?

@nguyentvan7
Copy link
Collaborator

oops didnt send it. the contrast on the bottom right of pico card is a bit bad, could we add some shading/shadow there or something?

@frzyc frzyc requested a review from nguyentvan7 May 9, 2024 19:04
@@ -69,7 +69,6 @@ export function ArtifactCardPico({
position: 'absolute',
fontSize: '0.75rem',
lineHeight: 1,
opacity: 0.85,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I barely even notice this change tbh I was thinking something more like this (just changed backgroundcolor of sqbadge to #22)
image

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could tweak it later i guess, another option is to apply darker gradients at the topleft and bottom right corner (so there isnt a harsh rectangle line, which is what I'm trying to avoid)

@frzyc frzyc merged commit a07606f into master May 9, 2024
6 checks passed
@frzyc frzyc deleted the teamcard_glowup branch May 9, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants