-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TeamCard refactor #2082
TeamCard refactor #2082
Conversation
[frontend] [Thu May 9 06:41:10 UTC 2024] - Deployed 9f4d16d to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu May 9 06:42:49 UTC 2024] - Deployed cb8a8b9 to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu May 9 06:46:39 UTC 2024] - Deployed 38c8c23 to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Thu May 9 19:06:34 UTC 2024] - Deployed cabab95 to https://genshin-optimizer-prs.github.io/pr/2082/frontend (Takes 3-5 minutes after this completes to be available) [Thu May 9 19:29:29 UTC 2024] - Deleted deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shading comment
+
Should we make the team name+header a bit bigger? maybe 2 line tall? Kinda depends on if people identify teams via characters or name primarily maybe.
What's a Shading comment? |
oops didnt send it. the contrast on the bottom right of pico card is a bit bad, could we add some shading/shadow there or something? |
@@ -69,7 +69,6 @@ export function ArtifactCardPico({ | |||
position: 'absolute', | |||
fontSize: '0.75rem', | |||
lineHeight: 1, | |||
opacity: 0.85, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I barely even notice this change tbh I was thinking something more like this (just changed backgroundcolor of sqbadge to #22)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could tweak it later i guess, another option is to apply darker gradients at the topleft and bottom right corner (so there isnt a harsh rectangle line, which is what I'm trying to avoid)
Describe your changes
Team cards currently only show the team name, and the 4 characters in the team.
However, it doesn't really tell which loadout/build the characters are using, which infers a lot of context in how the team is used.
The loadout and builds are only shown on hovering over each character.
This is an alternative layout for the teamcard, that shows all that data without the hovering barrier.
Additionally, remove the SqBadges in artifact/weaponcardpico. It was adding too much color and blocking out too much realestate on those tiny cards.
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.