Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sigewinne + weapon #2262

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Add Sigewinne + weapon #2262

merged 4 commits into from
Jun 25, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Add Sigewinne
  • Add Silvershower Heartstrings

Issue or discord link

Testing/validation

Tested site. Scalings, translations look correct for both

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc June 23, 2024 22:51
Copy link
Contributor

github-actions bot commented Jun 23, 2024

[frontend] [Sun Jun 23 22:55:47 UTC 2024] - Deployed 95fa0c3 to https://genshin-optimizer-prs.github.io/pr/2262/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Jun 24 15:45:54 UTC 2024] - Deployed 6a234f7 to https://genshin-optimizer-prs.github.io/pr/2262/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jun 25 15:01:49 UTC 2024] - Deleted deployment

Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyentvan7 nguyentvan7 merged commit 34b1012 into master Jun 25, 2024
6 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/sigewinne branch June 25, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants