Specify SPDX tag for semver #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semver utility is not widely packaged by distributions. As such projects may wish to incorporate the script directly as a helper to support packaging and versioning of a project. In such cases, it is important to ensure that the licence of the semver utility is maintained. Provide an Apache-2.0 SPDX tag [0][1] within the semver script to ensure the licencing is clear. [0] https://spdx.dev/ids/ [1] https://spdx.org/licenses/Apache-2.0.html Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
|
Looks like a good idea. The inserted tag looks correct to me (after checking the SPDX sites). I would suggest that a unit test be added that checks that the tag is present. Not critical, but then is someone decides to edit it out, the test will catch it. |
|
@ranger6 there, I added the test. |
|
Thanks for your contribution @kbingham |
|
Thank you! I'll use this latest version to support my release management for the libcamera project. This semver script is very useful to support the process. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semver utility is not widely packaged by distributions. As such projects may wish to incorporate the script directly as a helper to support packaging and versioning of a project.
In such cases, it is important to ensure that the licence of the semver utility is maintained.
Provide an Apache-2.0 SPDX tag [0][1] within the semver script to ensure the licencing is clear.
[0] https://spdx.dev/ids/
[1] https://spdx.org/licenses/Apache-2.0.html
Signed-off-by: Kieran Bingham kieran.bingham@ideasonboard.com