Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinging 'dropbox.com' not possible in some regions #12

Closed
DongRih opened this issue Oct 9, 2019 · 1 comment
Closed

Pinging 'dropbox.com' not possible in some regions #12

DongRih opened this issue Oct 9, 2019 · 1 comment

Comments

@DongRih
Copy link

DongRih commented Oct 9, 2019

in get.sh, line 14 to 27 :

#check internet connection
echo "`$Dt` waiting for internet connection"
r=1;i=0
while [ $r != 0 ]; do
  if [ $i -gt 60 ]; then
    ping -c 1 -w 3 dropbox.com
    echo "`$Dt` error! no connection detected" 
    exit 1
  fi
  ping -c 1 -w 3 dropbox.com >/dev/null 2>&1
  r=$?
  if [ $r != 0 ]; then sleep 1; fi
  i=$(($i + 1))
done

Dropbox is pinged to check whether internet connection is available. But due to some reasons, Dropbox is not reachable in China, thus pinging will never be succeed. Ping www.microsoft.com or aws.amazon.com may be a better choice.

@fsantini
Copy link
Owner

fsantini commented Oct 9, 2019

Thanks! Fixed in Master.

@fsantini fsantini closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants