Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--server=false results in mismatch #21

Closed
IvanRainbolt opened this issue May 24, 2020 · 6 comments
Closed

--server=false results in mismatch #21

IvanRainbolt opened this issue May 24, 2020 · 6 comments

Comments

@IvanRainbolt
Copy link

If the template switch -s=false or --server=false like:
dotnet new bolero-app -o BoleroNoServer -s=false
is used, the resulting solution still has the project files for the .Server in the folder.

The Server project is not in the .sln file, so it does not show in VS.

The Client Main.fs file also contains:
#if DEBUG
|> Program.withHotReload
#endif

and the Book Service items as well.

@zakaluka
Copy link

I just noticed the same thing when testing some PWA-related items. Adding the ability to enabled/disable remoting (as part of dotnet new) may be helpful in preventing the server from being created.

@Tarmil
Copy link
Member

Tarmil commented May 25, 2020

So, this switch is supposed to only have an effect when combined with --minimal=true, because the full template uses remoting. So we should either fix the fact that the project is still removed from the solution with -s=true -m=false, or implement a proper remote-less version of the full template.

@zakaluka
Copy link

Would the simpler solution be to make that clear in the help text and the documentation?

@Tarmil
Copy link
Member

Tarmil commented May 25, 2020

They do both say that the server flag is ignored if minimal=false. I'm open to a better wording though!

@zakaluka
Copy link

zakaluka commented May 25, 2020 via email

@Tarmil
Copy link
Member

Tarmil commented May 7, 2021

The dotnet project template has been modified and now accepts the server=false minimal=false combination (by replacing the remote calls with requests to a static JSON file).

@Tarmil Tarmil closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants