Fix copyright merging for all copyright styles. #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes patterns not matching `spdx-c`, `spdx-symbol`, and `string-symbol` correctly, thereby causing merges to not occur.
Import _COPYRIGHT_STYLES dict in tests/test_main_annotate_merge.py, and loop over all copyright styles in test_annotate_merge_copyrights_simple() to check that copyright merging works with all variants.
There seems to be an encoding issue in the windows test runner when reading or writing the copyright symbol. Let's see if this helps...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes patterns not matching
spdx-c,spdx-symbol, andstring-symbolcorrectly, thereby causing merges to not occur.Also change
test_annotate_merge_copyrights_simple()to test copyright merging for all copyright styles defined in_COPYRIGHT_STYLESdictionary.