Improve source distribution #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI tells me that the importlib mode does indeed cause issues; I will probably drop it then. But let me know if that is something you would be interested in the future. |
khardix
force-pushed
the
pr/improve-source-distribution
branch
from
2b3865c
to
598a3be
Compare
|
Hi @khardix and thanks for the PR! Apologies for the lack of communication. I have created #993 to track a switch to importlib. The reason it didn't work when you tried making that change in this repository is because the |
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently taken maintenance of reuse in Fedora, and these are fixes for two minor issues I ran into while packaging the most current version (3.0.2).
CONTRIBUTING.mdis missing from the sdist archive, but is included/used by Sphinx while building docs. So currently the docs cannot be built from sdist.Our pytest invocation does some black magic with PYTHONPATH, and with the current configuration it leads to bunch of
ImportMismatchErrors when the tests are being collected. Swithing toimportlibmode (which should be the blessed way nowadays) fixes them and allows the tests to run (successfully on my machine).This change looks fine to me, but I'm fine with dropping it if it would cause any issues to anyone else.