Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a floating 'campaign by' text on the main page #57

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Oct 31, 2023

Suggestion by Ana Galan.

Screens:

Wide screen (show floater)

Screenshot from 2023-10-31 14-42-23

1920px wide screen

Screenshot from 2023-10-31 20-15-06

Narrow screen (don't show floater)

Screenshot from 2023-10-31 14-42-32

Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Copy link
Member

@mxmehl mxmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but looks good. However, the wording could be improved, see comment.

site/i18n/en.json Outdated Show resolved Hide resolved
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca carmenbianca merged commit 1925ef2 into fsfe:main Feb 1, 2024
2 checks passed
@mxmehl mxmehl mentioned this pull request Feb 6, 2024
carmenbianca added a commit to carmenbianca/reuse-website that referenced this pull request May 21, 2024
Co-authored-by: mxmehl <max.mehl@fsfe.org>
Co-authored-by: carmenbianca <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca added a commit to carmenbianca/reuse-website that referenced this pull request May 21, 2024
Co-authored-by: mxmehl <max.mehl@fsfe.org>
Co-authored-by: carmenbianca <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants