Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project reference cleanup #1980

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Conversation

BlythMeister
Copy link
Contributor

@BlythMeister BlythMeister commented Jun 5, 2018

  • Remove the fromp2p attributes (These appear to have been depricated now.)
  • Remove reference to fake.core.context where replaced by fakevar
  • Remove other redundant project references

@BlythMeister BlythMeister changed the title WIP - Project reference cleanup Project reference cleanup Jun 7, 2018
@BlythMeister
Copy link
Contributor Author

@matthid this looks quite scary...but it compiles so i can only assume all those project references were redundant....

@BlythMeister BlythMeister changed the base branch from release/rc to master June 7, 2018 11:15
@BlythMeister BlythMeister changed the base branch from master to release/next June 7, 2018 11:16
It would appear that this setting is actually no longer required when taking a project reference
This is replaced by Fake.Core.FakeVar
@matthid
Copy link
Member

matthid commented Jun 7, 2018

Wow very cool. Yes I think if it compiles it should be fine.

@BlythMeister
Copy link
Contributor Author

@matthid the only real risk i can see here is that if someone is getting a package because of the project dependency they will need to update their dependencies to include as a 1st level dependency rather than a transient...but i don't see that as a reason not to push this.

@BlythMeister
Copy link
Contributor Author

also, there is no nice tooling for this...it was a manual exercise of removing all project deps and adding them back in manually as needed!

@matthid
Copy link
Member

matthid commented Jun 7, 2018

Thanks!

@matthid matthid merged commit 86bd3e1 into fsprojects:release/next Jun 7, 2018
@BlythMeister BlythMeister deleted the P2P branch May 11, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants