Migrated UserInputHelper into Fake.Core.UserInput #1997
Conversation
| /// UserInput.getUserInput prompt | ||
| [<RequireQualifiedAccess>] | ||
| module UserInput = | ||
| let internal erasePreviousChar () = |
There was a problem hiding this comment.
The code if the module needs to be intended to the right in order to get rid of the warning:
C:\projects\fake-6w516\src\app\Fake.Core.UserInput\UserInput.fs(11,1): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (10:1). Try indenting this token further or using standard formatting conventions. [C:\projects\fake-6w516\src\app\Fake.Core.UserInput\Fake.Core.UserInput.fsproj]
Basically just intend from line 11 to line 63
| /// | ||
| /// UserInput.getUserInput prompt | ||
| [<RequireQualifiedAccess>] | ||
| module UserInput = |
There was a problem hiding this comment.
This module is copied from an existing one from FakeLib, correct? Can we change the obsolete warnings of the existing module in FakeLib to point to this one?
There was a problem hiding this comment.
One extension to that: We also need to add this new module to FakeLib in order to enable the migration path.
There was a problem hiding this comment.
This should be addressed by linking the file in FakeLib which referenced by the Legacy-FAKE solution right?
|
The module itself looks good, thanks! Just some organizational stuff left... |
|
I believe this should be ready now, let me know if further adjustments are needed |
The only thing that comes to mind it to add a link to the api-docs in https://github.com/fsharp/FAKE/blob/release/next/help/templates/template.cshtml Otherwise it looks good, thanks! |
|
Added the reference in |
|
Yes exactly, thanks! |
No description provided.