Teamcity build parameters

[vbfox]

Description

TeamCity exposes a lot of build parameters that FAKE 4 made accessible but the class and some associated methods were made internal (and unused) in FAKE 5

This PR add them back with a slighty modified API.

The public API surface change is :

module Fake.BuildServer.TeamCity =
+	module BuildParameters =
+		System: Map<string, string>
+		Configuration: Map<string, string>
+		Runner: Map<string, string>
+		All: Map<string, string>
+	type FileChangeType = // DU
+	type FileChange = // Record
	type Environment =
+		Branch: string option
+		BranchDisplayName: string option
+		IsDefaultBranch: string option
+		CheckoutDirectory: string option
+		ChangedFiles: FileChange  list option
+		RecentlyFailedTests: string list option

It add build parameters for people who need them (We query all VCS properties that way for example) and exposes some common ones in Environment.

PS: Lot of things can be done via build parameters, they contains for example the PATH of all versions of visual studio installed that are detected by TC

[vbfox]

No idea why travis didn't update the GH status but the build is successful

[BlythMeister]

I like this, I currently pull the branch in a nasty way!

[matthid]

I'm generally OK, but somehow I'm a bit hesitant about the concrete API (or function names, I'm not sure)

[matthid]

Somehow I don't like this API TeamCity.BuildParamters.getAllSystem()

How about making the module internal and adding

TeamCity.getAllSystemParameters()

not sure if that reads better. If you disagree or find a better solution I'm OKish with leaving as is or discussing another alternative.

[vbfox]

We can, I tried grouping them but it's not mandatory, i'll try to see if I can find good names for all

[vbfox]

In the end the thing that might read the best is to remove the tryXXX and have the getters as static properties

TeamCity.BuildParameters.System |> Map.tryFind "foo"

Would it be ok ?

[matthid]

If we add these to the environment then we might add the other APIs from BuildParameters as well?

[vbfox]

Possible but I thing it's nice that this class/module only contains specific parameters, consumers here don't care that it came via the java parameters file or via environment variables as long as it's something team city make available

[vbfox]

New version with a smaller API surface.

Reading properties syntax become :

let fooBar = TeamCity.BuildParameters.System |> Map.tryFind "foo.bar"

[matthid]

Yes looks good. Thanks!
One the one hand I'd like to push people into using "platform independent" APIs (therefore the low API surface of the build server modules). But I see from working with the TeamFoundation module lately that this is not always so easy..