Append the content headers so the header Content-Type is included in the headers list
#2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we add a test for this? |
|
Thanks for looking into this, yes this probably is the correct thing to do. Still a bit unexpected that the behavior changed oO |
|
Unfortunately writing tests is a bit beyond my f# capabilities, wouldn't know where to start, only really learnt enough to get Fake working with our projects. Hopefully that is not a problem. |
|
Ok I'll try to come up with a test, but it will take a couple of days |
matthid
added
help wanted
needs-tests
|
Sounds good thanks. We would very much like this fix so if there's anything I can help with please let me know. |
|
Yes, I just want to ensure we don't regress on this before merging |
|
Thanks again for figuring out the root cause and providing a fix, I could reproduce with a test and refactored the code a bit (feel free to review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2124
I'm not an expert with f# but it seems a simple fix and I have tested this in isolation and it fixes the bug mentioned in the other issue.
Hopefully this is ok.