Fix Console runner to support space in temp path #2180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user profile and therefore the temp folder contained spaces, they would be passed to the NUnit runner as two separate arguments, so running unit tests would not work
matthid
reviewed
Nov 1, 2018
| @@ -317,7 +317,7 @@ let internal createProcess (setParams : NUnit3Params -> NUnit3Params) (assemblie | |||
| //let processTimeout = TimeSpan.MaxValue // Don't set a process timeout. The timeout is per test. | |||
|
|
|||
| let path = Path.GetTempFileName() | |||
| let args = (sprintf "@%s" path) | |||
| let args = (sprintf "\"@%s\"" path) | |||
There was a problem hiding this comment.
Hm, can you instead use the Args class, this way it should work with other special cases of windows escaping horror as well. Also we might want to add a simple test to check that it is properly escaped.
|
Thanks for reporting and sending a PR. I added a test and a slightly different fix in order to handle some other edge cases as well (as indicated by my comment above), see d6d596f |
|
Thanks for doing the changes, the last days have been so creazy that it did not find the time to make the changes you had proposed myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user profile and therefore the temp folder contained spaces, they would be passed to the NUnit runner as two separate arguments, so running unit tests would not work