Add default proxy credentials when connecting to GitHub #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue referred in the code octokit/octokit.net#963 has since been fixed. The timeout can be set via a method on the client, and per the last comment octokit/octokit.net#963 (comment) this needs to be set on the release upload request as well. If not set, the default per-request timeout of 100 seconds is configured.
|
Build fails because although fake will install the dotnet SDK specified in |
|
Thanks, looks reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Primarily, this adds the default credentials as the default proxy credentials when connecting to GitHub. This is per dotnet/runtime#25745 (comment). I've tested this in our environment (where this had previously failed), and the issue is resolved.
Additionally, the code had a workaround for a missing Octokit hook to increase the timeout on uploading release assets. This has since been added to Octokit in octokit/octokit.net#1693, so I've replaced the workaround with code to make use of this instead.
Fixes #2505