Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new function to WiX helper for retrieving file id from wixDir output #804

Merged
merged 5 commits into from
May 25, 2015

Conversation

DigitalFlow
Copy link
Contributor

This is the first implementation of my function for retrieving a file id from a wixDir string.
It takes the wixDir string and a regex to match the executable name, which you are trying to get the id from.
It returns the first match for the given regex out of the wixDir string.
I'll add a test case soon.

/// - `fileRegex` - Regex which matches the file name
///
/// ## Sample
/// let directoryString = wixDir (fun file -> true) true (DirectoryInfo directoryWithFilesForSetup)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sample code needs to be indented like https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/ZipHelper.fs#L165

@forki
Copy link
Member

forki commented May 20, 2015

very cool. only a small suggestion for the sample

@DigitalFlow
Copy link
Contributor Author

I fixed the line indentation in the sample and added a test case, not sure if it is at the right location, because I can't open FAKE correctly as it seems...
Any suggestions where to put the tests?

@forki
Copy link
Member

forki commented May 20, 2015

You can't open?

@DigitalFlow
Copy link
Contributor Author

When trying to run the "getFileIdFromWiXString" function in the test, I get a "getFileIdFromWiXString is undefined" error.
So it seems as if I didn't open or load FAKE correctly to use the FAKE functions in my test case.

@DigitalFlow
Copy link
Contributor Author

Ok, fixed the build, my tests went into the Test.Fake.Deploy.Web project, I had to add Fake as a reference, forgot that.

@DigitalFlow
Copy link
Contributor Author

I wanted to get rid of the need to manually create a WiX XML.
So now there is a function which creates a standard WiX XML and various types for creating features, custom actions and install executions.
Just use the function for creating a WiXScript, create features, custom actions and so on as you wish and then pass them to the fillInWixScript function.
You can then run the WiX function without having to ever write a WiX XML yourself.
Tests follow.

forki added a commit that referenced this pull request May 25, 2015
Added new function to WiX helper for retrieving file id from wixDir output
@forki forki merged commit 1b51ce9 into fsprojects:develop May 25, 2015
@forki
Copy link
Member

forki commented May 25, 2015

cool thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants