New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSharp.Compiler.Service nupkg without FSharp.Compiler.Service.MSBuild.v12.dll #675
Comments
This would be really useful. On the F# Notebook tool (https://github.com/fsprojects/IfSharp) we use the F# Compiler Service to process F#. By using the NuGet we the FSharp.Compiler.Service.MSBuild.v12.dll reference which I guess we don't need, but have been just ignoring. We recently had a confusing crash. On machine-A with only Visual Studio 2017, someone was able to build the tool from source and run successfully. However, a build from machine-B with Visual Studio 2017 (AND other earlier versions) was failing on Machine-A, I located the issue as having these files:
(with timestamps with the year as 2015) Neither build shows errors or warnings. When I deleted the files, which took a while to figure out, it seems to work properly. I've worked around this by manually removing the reference FSharp.Compiler.Service.MSBuild.v12.dll from the project and it now consistently builds between machines. Unfortunately any time someone runs
|
@cgravill Based on that we should certainly separate the packages |
@cgravill If you or anyone gets a chance to submit the PR for the package building then I can publish (not sure when we'd get to it otherwise) |
@dsyme understood, I'll add it to my list though I'm not sure when I'll get to it either so anyone else is extremely welcome to go ahead and make us happy! |
Closing, done |
I know we can manually remove it from a project, but it's just going to keep getting installed repeatedly.
Either having FSharp.Compiler.Service keep the msbuild dll and adding a new package like FSharp.Compiler.Service.Core or removing the msbuild dll and adding a new package like FSharp.Compiler.Service.MSBuild would be good.
The text was updated successfully, but these errors were encountered: