Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Paket #679

Closed
wants to merge 1 commit into from
Closed

Using Paket #679

wants to merge 1 commit into from

Conversation

forki
Copy link
Member

@forki forki commented Sep 19, 2014

This is done mostly by paket convert-from-nuget

At the moment it's only for discussion.

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

I've not been following paket closely, can you share the pros/cons of using paket here?

  • Will it work on Mono
  • If I clone the project, open the .sln will it fetch packages and just work without having to run any command line first?
  • Why are all the references changed? We have separate proj files for different .net profiles, and it seems everything is included in all with conditionals, instead of just including the relevant reference version

@@ -0,0 +1 @@
Zlib.Portable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. versions are only specified in the paket.dependencies file.
This makes things much easier

@forki
Copy link
Member Author

forki commented Sep 20, 2014

Will it work on Mono

yes

If I clone the project, open the .sln will it fetch packages and just work without having to run any command line first?

not yet.

Why are all the references changed?

different way of thinking - you solved already solved this differently.

@forki forki closed this Sep 20, 2014
@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Don't close just yet, I want to discuss this. NuGet has a lot of annoyances and I'd like to try Paket

@forki forki reopened this Sep 20, 2014
@ovatsus
Copy link

ovatsus commented Sep 20, 2014

One of the things NuGet does that annoys me is include version numbers on the references on the project files. This means everytime we update, we have to go chase every .fsx and make sure the #r's are up to date. Paket seems to get rid of this problem

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

I'm not saying the current approach we have to the different profiles is the best one, want to understand how paket does it and pros/cons of both approaches. Not entirely happy with the current system

@forki
Copy link
Member Author

forki commented Sep 20, 2014

make sure the #r's are up to date. Paket seems to get rid of this problem

yes

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Is Nuget still required to be checked in? I noticed you deleted Nuget.config, but not the .exe

@forki
Copy link
Member Author

forki commented Sep 20, 2014

I'm not saying the current approach we have to the different profiles is the best one

Paket is installing references for all the possible profiles into the same project file. This allows you to just switch targetframework in VS and you don't need nuget reinstall.

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Ok, there is one caveat then. Only the pcl versions of fsharp.data reference zlib.portable, the full .net version doesn't need it. The conversion step is loosing that. Probably because I have all .fsproj files on the same dir, and there is a global .references file per folder. Maybe there should be a .references file per .fsproj?

@forki
Copy link
Member Author

forki commented Sep 20, 2014

Maybe there should be a .references file per .fsproj?

yes you can do this. But automatic conversion doesn't find such things.

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Are there plans to have the fsproj's modified so if you build inside VS it will automatically call paket -update?

@forki
Copy link
Member Author

forki commented Sep 20, 2014

yes. fsprojects/Paket#94

but personally I can't understand this obsession ;-)

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Well, I think you shouldn't be required to know about NuGet, Paket or the build.fsx to be able to build and test a project. Simply opening the .sln should work. I think this is very important for users new to the ecosystem, we don't want to scare them away with "complicated" build processes (eve if they are simple, the unknown always sounds complicated)

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

I wasn't talking about a VS addin, I was talking about msbuild proj.sln calling packet behind the scenes (the pre-VS2013 model where nuget added a Import .targets to your projects, not the new one where VS does it magically)

@forki
Copy link
Member Author

forki commented Sep 20, 2014

I understand your concerns, but disagree. ;-)

Reading a readme which clearly states "run build.bat" is not too much for a
beginner.
No I think it's valuable, because so they get trust into the system and see
how they can run tests and check if everything still works.

2014-09-20 12:47 GMT+02:00 Gustavo Guerra notifications@github.com:

Well, I think you shouldn't be required to know about NuGet, Paket or the
build.fsx to be able to build and test a project. Simply opening the .sln
should work. I think this is very important for users new to the ecosystem,
we don't want to scare them away with "complicated" build processes (eve if
they are simple, the unknown always sounds complicated)


Reply to this email directly or view it on GitHub
#679 (comment).

@quintusm
Copy link

Speaking for the novices here I cast my vote with ovatsus here, I think if at all possible it should be set up so that opening .sln and clicking on run just works.

@forki
Copy link
Member Author

forki commented Sep 20, 2014

ok. let's do this. ;-)

Will add paket.target very soon

2014-09-20 12:57 GMT+02:00 Quintus Marais notifications@github.com:

Speaking for the novices here I cast my vote with ovatsus here, I think if
at all possible it should be set up so that opening .sln and clicking on
run just works.


Reply to this email directly or view it on GitHub
#679 (comment).

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Cool, will switch to Paket once that is done and Mono is supported

@forki
Copy link
Member Author

forki commented Sep 20, 2014

mono is already supported

2014-09-20 13:08 GMT+02:00 Gustavo Guerra notifications@github.com:

Cool, will switch to Paket once that is done and Mono is supported


Reply to this email directly or view it on GitHub
#679 (comment).

@ovatsus
Copy link

ovatsus commented Sep 20, 2014

Ah, yes, you said that on the beginning, missed that

@forki
Copy link
Member Author

forki commented Sep 20, 2014

added paket.targets

ovatsus pushed a commit that referenced this pull request Sep 20, 2014
ovatsus pushed a commit that referenced this pull request Sep 20, 2014
ovatsus pushed a commit that referenced this pull request Sep 20, 2014
ovatsus pushed a commit that referenced this pull request Sep 20, 2014
@ovatsus ovatsus closed this Sep 20, 2014
@forki forki deleted the paket branch September 20, 2014 16:20
ovatsus pushed a commit that referenced this pull request Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants