-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cross targeting msbuild projects (multiple target framework) #168
support cross targeting msbuild projects (multiple target framework) #168
Conversation
as a note @Krzysztof-Cieslak @kjnilsson @rneatherway this doesnt had any new configuration, just fix for crossgen, using the first target framework of the list. Fix also a common scenario:
pratically traversing the project references, i ask to msbuild what target framework the project reference should use. But now is easier to add because:
|
Ah this repo https://github.com/enricosada/DotnetNewFsprojTestingSamples contains some examples ready to use with some scenario (if can help vim/emacs testing) |
Is there much more to come along these lines? I think it'll be more efficient if I take a batch of updates over to emacs. |
@rneatherway Dont think so, maybe just a perfomance improvement for bigger solution ( https://github.com/fsharp/FsAutoComplete/blob/master/src/FsAutoComplete.Core/ProjectCoreCracker.fs#L93 and #161 ) but depends if i have time to do it (not in short term anyway, maybe next month). Other changes require changes to public api, so need discussion before do it. Stuff like:
support new sdk on mono will wait a bit, because sdk 2.0 is changing... |
184b37b
to
cf9678d
Compare
Ah sorry I caused a conflict here, would you mind updating? |
@rneatherway sure np, i'll always rebase as needed. |
these with `<TargetFrameworks>` (plural) from root, if crossgen, choose the first target (atm FSAC doesnt support pass a preference) After that, redo the inspect with that target framework, and ask msbuild about what frameworks the project references should use
output file fsc argument can be `-o` or `--out`
cf9678d
to
20f3326
Compare
nice behaviour. |
these with
<TargetFrameworks>
(plural)from root, if crossgen, choose the first target (atm FSAC doesnt support pass a preference)
After that, redo the inspect with that target framework, and ask msbuild about what frameworks
the project references should use
fix #162