Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Dotnet.ProjInfo to v0.31 #337

Merged
merged 5 commits into from Feb 18, 2019
Merged

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Feb 11, 2019

  • upgrade Dotnet.ProjInfo to v0.31
  • drop fsharp.net.sdk projects support

NOTE the Dotnet.ProjInfo v0.31 doesnt create anymore the helper target file in obj dir

@enricosada enricosada changed the title [WIP] upgrade Dotnet.ProjInfo to v0.31 upgrade Dotnet.ProjInfo to v0.31 Feb 13, 2019
@enricosada enricosada changed the title upgrade Dotnet.ProjInfo to v0.31 [WIP] upgrade Dotnet.ProjInfo to v0.31 Feb 13, 2019
@enricosada enricosada mentioned this pull request Feb 13, 2019
@enricosada enricosada changed the title [WIP] upgrade Dotnet.ProjInfo to v0.31 upgrade Dotnet.ProjInfo to v0.31 Feb 13, 2019
@enricosada
Copy link
Contributor Author

waiting to fix and merge #332 first

@baronfel
Copy link
Contributor

woo let's merge this sucker :D

@enricosada enricosada force-pushed the upgrade_dpi branch 2 times, most recently from 38917a1 to 80f5729 Compare February 14, 2019 21:46
@baronfel
Copy link
Contributor

Should we report the Mono weekly reflection failure that's failing the tests?

System.NotImplementedException: The method or operation is not implemented.
  at System.Reflection.Emit.AssemblyBuilder.get_ReflectionOnly () [0x00000] in <dfbc4bb8759d4df18fd61c54e0b9082a>:0 
  at Microsoft.FSharp.Reflection.Impl.tryFindCompilationMappingAttributeFromType (System.Type typ) [0x00012] in <5b02f7c8dff9fae1a7450383c8f7025b>:0 
  at Microsoft.FSharp.Reflection.Impl.tryFindSourceConstructFlagsOfType (System.Type typ) [0x00000] in <5b02f7c8dff9fae1a7450383c8f7025b>:0 
  at Microsoft.FSharp.Reflection.Impl.isExceptionRepr (System.Type typ, System.Reflection.BindingFlags bindingFlags) [0x00000] in <5b02f7c8dff9fae1a7450383c8f7025b>:0 
  at Microsoft.FSharp.Reflection.Impl.getTypeOfReprType (System.Type typ, System.Reflection.BindingFlags bindingFlags) [0x00000] in <5b02f7c8dff9fae1a7450383c8f7025b>:0 
  at Microsoft.FSharp.Reflection.FSharpType.IsUnion (System.Type typ, Microsoft.FSharp.Core.FSharpOption`1[T] bindingFlags) [0x00026] in <5b02f7c8dff9fae1a7450383c8f7025b>:0 
  at (wrapper dynamic-method) Microsoft.FSharp.Reflection.FSharpType.Boolean IsUnion(System.Type, Microsoft.FSharp.Core.FSharpOption`1[System.Reflection.BindingFlags])(object,object[])

It'd be kinda bad if FSharpType.IsUnion and friends wouldn't be able to run in FSI.

@baronfel
Copy link
Contributor

@baronfel
Copy link
Contributor

I raised an issue at mono/mono#13028 to discuss the NotImplementedException

the `Dotnet.Proj.Info` >= v0.20 has deprecated these

The `FSharp.NET.Sdk` style projects are just for .NET Core Sdk v1 and can be upgrade to normal .NET Sdk projects targeting same .NET Core Sdk v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants